Rsamigullin/addstartnodepool commands#3990
Merged
zhoxing-ms merged 17 commits intoAzure:mainfrom Oct 25, 2021
rsamigullin:rsamigullin/addstartnodepool-commands
Merged
Rsamigullin/addstartnodepool commands#3990zhoxing-ms merged 17 commits intoAzure:mainfrom rsamigullin:rsamigullin/addstartnodepool-commands
zhoxing-ms merged 17 commits intoAzure:mainfrom
rsamigullin:rsamigullin/addstartnodepool-commands
Conversation
rsamigullin
requested review from
andyliuliming and
zqingqing1
as code owners
Collaborator
|
aks |
FumingZhang
requested changes
Oct 20, 2021
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
FumingZhang
approved these changes
Oct 20, 2021
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
LGTM, please resolve the conflicts with main branch 😃
Contributor
|
@rsamigullin Could you write the description of these changes in |
Member
|
As a reminder, the latest version has been updated to 0.5.38 and you may take 0.5.39 |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
zhoxing-ms
approved these changes
Oct 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.